[Intel-gfx] [PATCH 2/2] drm/i915/opregion: update cadl based on actually active outputs

[Maarten Lankhorst]

Op 25-08-16 om 14:53 schreef Jani Nikula:
> Previously we've just shoved the first eight devices in DIDL to CADL
> (list of active outputs). Some of the active outputs may have been left
> outside of CADL. The problem is, some BIOS implementations prevent
> laptop brightness hotkey propagation if the flat panel is not active.
>
> Now that we have connector to acpi device id mapping covered, we can
> update CADL based on which outputs are actually active.
>
> v3: actually git add the dev->dev_priv change.
>
> v4: update cadl in intel_shared_dpll_commit() if intel_state->modeset
>     (Maarten)
>
> v5: use crtc mask, not ->active to determine active outputs (Maarten)
>     Move first cadl update to after hardware readout (Maarten)
Much better! I don't dare to do a thorough review of the non-atomicy parts, but idea looks good.

Acked-by: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>