[Intel-gfx] [PATCH v2] drm/i915: don't track relative-constants-mode

Chris Wilson chris at chris-wilson.co.uk
Fri Aug 26 19:55:57 UTC 2016


On Fri, Aug 26, 2016 at 08:46:25PM +0100, Dave Gordon wrote:
> @@ -1520,6 +1528,14 @@ static void eb_export_fence(struct drm_i915_gem_object *obj,
>  	if (ret)
>  		return ret;
>  
> +	if (instp_mode != I915_EXEC_CONSTANTS_REL_GENERAL) {
> +		/* Restore default value of INSTPM */
> +		ret = emit_instpm(params->request, instp_mask,
> +				  I915_EXEC_CONSTANTS_REL_GENERAL);
> +		if (ret)
> +			return ret;

We can't return an error at this point, we are committed to executing
the batch. And we do expect to see at least an EINTR here occasionally.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list