[Intel-gfx] [PATCH] drm/i915: remove leftover for_each_intel_crtc_masked

Jani Nikula jani.nikula at intel.com
Mon Aug 29 09:06:14 UTC 2016


On Mon, 29 Aug 2016, Ander Conselvan De Oliveira <conselvan2 at gmail.com> wrote:
> On Thu, 2016-08-25 at 15:04 +0300, Jani Nikula wrote:
>> The last user of for_each_intel_crtc_masked macro was removed in
>> 
>> commit 0a9ab303b87a94115e361a7f3a15d9f481bc453b
>> Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
>> Date:   Tue Apr 21 17:13:04 2015 +0300
>> 
>>     drm/i915: Remove all *_pipes flags from modeset
>> 
>> Get rid of the unused macro.
>> 
>> Cc: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira at intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
>
> Reviewed-by: Ander Conselvan de Oliveira <conselvan2 at gmail.com>

Pushed, thanks.

BR,
Jani.

>
>> ---
>>  drivers/gpu/drm/i915/intel_display.c | 8 --------
>>  1 file changed, 8 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/intel_display.c
>> b/drivers/gpu/drm/i915/intel_display.c
>> index e4e6141b38c0..19ffd024ddec 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13128,12 +13128,6 @@ static bool intel_fuzzy_clock_check(int clock1, int
>> clock2)
>>  	return false;
>>  }
>>  
>> -#define for_each_intel_crtc_masked(dev, mask, intel_crtc) \
>> -	list_for_each_entry((intel_crtc), \
>> -			    &(dev)->mode_config.crtc_list, \
>> -			    base.head) \
>> -		for_each_if (mask & (1 <<(intel_crtc)->pipe))
>> -
>>  static bool
>>  intel_compare_m_n(unsigned int m, unsigned int n,
>>  		  unsigned int m2, unsigned int n2,
>> @@ -14585,8 +14579,6 @@ out:
>>  		drm_atomic_state_free(state);
>>  }
>>  
>> -#undef for_each_intel_crtc_masked
>> -
>>  /*
>>   * FIXME: Remove this once i915 is fully DRIVER_ATOMIC by calling
>>   *        drm_atomic_helper_legacy_gamma_set() directly.

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list