[Intel-gfx] [PATCH 17/17] drm/i915: Support explicit fencing for execbuf

[Joonas Lahtinen]

On su, 2016-08-28 at 21:46 +0100, Chris Wilson wrote:
> @@ -1915,6 +1979,16 @@ i915_gem_do_execbuffer(struct drm_device *dev, void *data,
>  	ret = execbuf_submit(params, args, &eb->vmas);
>  err_request:
>  	__i915_add_request(params->request, ret == 0);
> +	if (out_fence) {
> +		if (ret == 0) {
> +			fd_install(out_fence_fd, out_fence->file);
> +			args->rsvd2 &= ~((u64)0xffffffff << 32);

args->rsvd2 &= GENMASK_ULL(0, 31) or at least have some #define for
these. But I'd vote to add real variable names, either by renaming the
variables or by having an anonymous union if you will.

Regardsless;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation