[Intel-gfx] [PATCH 1/7] drm/i915/hsw+: set intel_crtc active once pipe is active

Mahesh Kumar mahesh1.kumar at intel.com
Wed Aug 31 14:04:07 UTC 2016


earlier implementation of "DDB writing" was using this flag before 
wait_for_vblank if we need to expand the DDB & it overlap with other 
pipe's DDB.
In that case, I observed on corner case requiring a cd-clock change, 
intel_update_watermarks was waiting for vblank, when it was called from 
haswell_crtc_enable function. This was leading to "vblank not available 
on crtc " warning (since vblank int was not yet enabled on that CRTC).
But as I can see we now no longer use wait for vblank during DDB writing 
if it's called from crtc_enable function after Paul's patch series, I 
can drop this patch all together.
thanks for review & input

Regards,
-Mahesh

On Wednesday 31 August 2016 04:21 PM, Maarten Lankhorst wrote:
> more state needs to be pre-calculated, rather than touching intel_crtc->active.
> Something like using the .initial_watermarks callback, we're so close to removing
> that non-atomic flag altogether.:-)
>
> ~Maarten



More information about the Intel-gfx mailing list