[Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

[Chris Wilson]

On Thu, Dec 01, 2016 at 02:07:19PM +0530, sourab gupta wrote:
> On Thu, 2016-12-01 at 00:11 -0800, Chris Wilson wrote:
> > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhingra at intel.com wrote:
> > > diff --git a/fs/Kconfig b/fs/Kconfig
> > > index 4bd03a2..7d0ac20 100644
> > > --- a/fs/Kconfig
> > > +++ b/fs/Kconfig
> > > @@ -200,6 +200,15 @@ config HUGETLBFS
> > >  config HUGETLB_PAGE
> > >  	def_bool HUGETLBFS
> > >  
> > > +config DRMFS
> > > +	bool "Drmfs file system support"
> > > +	depends on DRM
> > > +	help
> > > +	  Drmfs is a pseudo file system for drm subsystem output data.
> > > +
> > > +	  drmfs is a filesystem to hold miscellaneous output data from drm
> > > +	  subsystems.
> > > +
> > >  config ARCH_HAS_GIGANTIC_PAGE
> > >  	bool
> > >  
> > > diff --git a/fs/Makefile b/fs/Makefile
> > > index ed2b632..b34a96e 100644
> > > --- a/fs/Makefile
> > > +++ b/fs/Makefile
> > > @@ -120,6 +120,7 @@ obj-$(CONFIG_BEFS_FS)		+= befs/
> > >  obj-$(CONFIG_HOSTFS)		+= hostfs/
> > >  obj-$(CONFIG_CACHEFILES)	+= cachefiles/
> > >  obj-$(CONFIG_DEBUG_FS)		+= debugfs/
> > > +obj-$(CONFIG_DRMFS)		+= drmfs/
> > 
> > A filesystem does not have to live under fs/. Since this is dedicated
> > and tied to the lifetime of drivers/gpu/drm/drm.ko, we will be happier
> > with not adding a new MAINTAINERS entry.
> > -Chris
> > 
> Ok, agreed.
> So, should we have the drmfs/ source directory (with its associated
> files) under drivers/gpu/drm/?

If it sticks to one file, drmfs.c. (Slightly breaks the trend, but still
consistent as we are using the drmfs_ prefix.) If we follow the pattern
of having mount.c, file.c, dir.c etc, then drivers/gpu/drm/drmfs/

> Can you please suggest where should the associated 'DRMFS' config be
> defined? Should drm/Kconfig be a good place?

Yes, drivers/gpu/drm/Kconfig.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre