[Intel-gfx] [PATCH] drm/i915: remove redundant warnings

Chris Wilson chris at chris-wilson.co.uk
Fri Dec 2 11:24:57 UTC 2016


On Fri, Dec 02, 2016 at 10:58:38AM +0000, Matthew Auld wrote:
> If we've gotten this far then we must have already checked if the
> vma can fit into the vm when we inserted the mm node, and in turn
> must have also checked for the overflow.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>

The sanitychecks are a reasonable idea, since the result can be
catastrophic - but they are rather piecemeal and not desired in
production (just CI, and we want some really abusive test cases, of
which we already have a small selection).

I'd rather see these become GEM_BUG_ON (or GEM_WARN_ON) and more
complete coverage of the callbacks. i915_vma_bind() would give complete
coverage with minimal testing.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list