[Intel-gfx] [PATCH] drm/i915/execlists: Use list_safe_reset_next() instead of opencoding

Jani Nikula jani.nikula at linux.intel.com
Mon Dec 5 09:13:13 UTC 2016


On Sat, 03 Dec 2016, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> list.h provides a macro for updating the next element in a safe
> list-iter, so let's use it so that it is hopefully clearer to the reader
> about the unusual behaviour, and also easier to grep.
>
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Jani Nikula <jani.nikula at intel.com>

> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index a579088bddbd..1ad1468edbf9 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -733,7 +733,7 @@ static void execlists_schedule(struct drm_i915_gem_request *request, int prio)
>  			if (prio > READ_ONCE(p->signaler->priority))
>  				list_move_tail(&p->dfs_link, &dfs);
>  
> -		p = list_next_entry(dep, dfs_link);
> +		list_safe_reset_next(dep, p, dfs_link);
>  		if (!RB_EMPTY_NODE(&pt->node))
>  			continue;

-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list