[Intel-gfx] [PATCH] drm/i915/guc: Drop comment on fwif autogeneration

Jeff McGee jeff.mcgee at intel.com
Mon Dec 5 21:37:17 UTC 2016


Reviewed-by: Jeff McGee <jeff.mcgee at intel.com>

On Mon, Dec 05, 2016 at 05:04:29PM +0100, Arkadiusz Hiler wrote:
> The firmware interface file was initially partially autogenerated, but
> this is no longer the case.
> 
> It was never updated automatically, and a lot manual changes were
> introduced since.
> 
> From now on any changes to the firmware interface will be managed by
> hand, which gives us flexibility when it comes to structure reuse
> (HuC/GuC) and naming conventions.
> 
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Cc: Jeff Mcgee <jeff.mcgee at intel.com>
> Cc: Sagar A. Kamble <sagar.a.kamble at intel.com>
> Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_guc_fwif.h | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h b/drivers/gpu/drm/i915/intel_guc_fwif.h
> index 00ca0df..3202b32 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
> @@ -23,15 +23,6 @@
>  #ifndef _INTEL_GUC_FWIF_H
>  #define _INTEL_GUC_FWIF_H
>  
> -/*
> - * This file is partially autogenerated, although currently with some manual
> - * fixups afterwards. In future, it should be entirely autogenerated, in order
> - * to ensure that the definitions herein remain in sync with those used by the
> - * GuC's own firmware.
> - *
> - * EDITING THIS FILE IS THEREFORE NOT RECOMMENDED - YOUR CHANGES MAY BE LOST.
> - */
> -
>  #define GFXCORE_FAMILY_GEN9		12
>  #define GFXCORE_FAMILY_UNKNOWN		0x7fffffff
>  
> -- 
> 2.7.4
> 


More information about the Intel-gfx mailing list