[Intel-gfx] [PATCH] drm/i915/guc: Drop comment on fwif autogeneration

[Srivatsa, Anusha]

>-----Original Message-----
>From: Hiler, Arkadiusz
>Sent: Monday, December 5, 2016 9:37 PM
>To: Srivatsa, Anusha <anusha.srivatsa at intel.com>
>Cc: intel-gfx at lists.freedesktop.org; Mcgee, Jeff <jeff.mcgee at intel.com>;
>Kamble, Sagar A <sagar.a.kamble at intel.com>
>Subject: Re: [PATCH] drm/i915/guc: Drop comment on fwif autogeneration
>
>On Tue, Dec 06, 2016 at 12:59:03AM +0100, Srivatsa, Anusha wrote:
>> >-----Original Message-----
>> >From: Hiler, Arkadiusz
>> >Sent: Monday, December 5, 2016 8:04 AM
>> >To: intel-gfx at lists.freedesktop.org
>> >Cc: Srivatsa, Anusha <anusha.srivatsa at intel.com>; Mcgee, Jeff
>> ><jeff.mcgee at intel.com>; Kamble, Sagar A <sagar.a.kamble at intel.com>
>> >Subject: [PATCH] drm/i915/guc: Drop comment on fwif autogeneration
>> >
>> >The firmware interface file was initially partially autogenerated,
>> >but this is no longer the case.
>> >
>> >It was never updated automatically, and a lot manual changes were
>> >introduced since.
>> >
>> >From now on any changes to the firmware interface will be managed by
>> >hand, which gives us flexibility when it comes to structure reuse
>> >(HuC/GuC) and naming conventions.
>> >
>> >Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
>> >Cc: Jeff Mcgee <jeff.mcgee at intel.com>
>> >Cc: Sagar A. Kamble <sagar.a.kamble at intel.com>
>> >Signed-off-by: Arkadiusz Hiler <arkadiusz.hiler at intel.com>
>> >---
>> > drivers/gpu/drm/i915/intel_guc_fwif.h | 9 ---------
>> > 1 file changed, 9 deletions(-)
>> >
>> >diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h
>> >b/drivers/gpu/drm/i915/intel_guc_fwif.h
>> >index 00ca0df..3202b32 100644
>> >--- a/drivers/gpu/drm/i915/intel_guc_fwif.h
>> >+++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
>> >@@ -23,15 +23,6 @@
>> > #ifndef _INTEL_GUC_FWIF_H
>> > #define _INTEL_GUC_FWIF_H
>> >
>> >-/*
>> >- * This file is partially autogenerated, although currently with
>> >some manual
>> >- * fixups afterwards. In future, it should be entirely
>> >autogenerated, in order
>> >- * to ensure that the definitions herein remain in sync with those
>> >used by the
>> >- * GuC's own firmware.
>> >- *
>> >- * EDITING THIS FILE IS THEREFORE NOT RECOMMENDED - YOUR CHANGES
>MAY
>> >BE LOST.
>> >- */
>>
>> With this removal of comment, do you feel moving the contents of
>intel_guc_fwif.h to intel_uc.c or renaming the file to intel_uc_fwif.h makes a lot
>of difference?
>
>I think this area could use some reorganization, but we should give it more
>thought before we do anything.
>
>Keeping all the GuC-related defines/structs that are used to communicate with
>FW and are prone to change in a separate file seems like a good idea.
>
>This would make them easier to manage in cases of any turbulence.
>
>I agree that `intel_uc_fwif.h` would be a good name, as your HuC patchset is
>reusing some of the intrfaces (e.g. css headers) for HuC.
>
>The rename can be done as part of the HuC effort. I'll give it some more thought
>today and send you a RFC version of the reorg to include in your patchset.
>
Sure. Thanks!

Anusha
>Cheers,
>Arek