[Intel-gfx] [RFC 5/5] drm: Do not log driver prefix in debug messages

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Dec 7 06:52:28 UTC 2016


Hi,

On 06/12/2016 19:49, Gustavo Padovan wrote:
> Hi Tvrtko,
>
> 2016-12-06 Tvrtko Ursulin <tursulin at ursulin.net>:
>
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> Driver prefix is a bit redundant in debug messages. If we choose
>> not to log it we change debug messages which used to look like this:
>>
>>  [i915:edp_panel_off [i915]] Wait for panel power off time
>>
>> to this:
>>
>>  [edp_panel_off [i915]] Wait for panel power off time
>
> Why not remove the second mention to the driver's name instead.
>
> [i915:edp_panel_off] looks more logic to me.

Would possibly be more readable yes, but the whole string comes from %ps 
AFAICS so I don't think we could split it.

Regards,

Tvrtko



More information about the Intel-gfx mailing list