[Intel-gfx] [PATCH igt] intel-ci: Do module loads first + last

Chris Wilson chris at chris-wilson.co.uk
Wed Dec 7 20:09:07 UTC 2016


On Wed, Dec 07, 2016 at 09:41:42PM +0200, Jani Nikula wrote:
> On Wed, 07 Dec 2016, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> > Do the module reload test first, so that it has the best chance of
> > succeeding without outside influence (broken driver). And then do it
> > last, so that it has the best chance of catching some missing
> > finalisation (e.g. memleak) over the lifetime of the testing.
> 
> I see your point, and maybe I worry too much, but running stuff with a
> reloaded module is never the normal use case. This makes all the test
> run with a reloaded module.

You can move the reload-inject to the end, but something I would like
for CI to start doing is not allowing i915 to load during the boot. We
miss error messages from that first load that do not appear again later.
:(

That again is an unusual configuration (so we still need
initramfs/builtin checking). Combitorial explosions of combitorial
explosions.

Anyway reload-final really should be the final operation irrespective of
this discussion :)
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list