[Intel-gfx] [PATCH] drm/i915: distinguish G33 and Pineview from each other

Jani Nikula jani.nikula at intel.com
Wed Dec 7 22:06:37 UTC 2016


On Wed, 07 Dec 2016, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> A lot of the checks involving g33 are apparently quite ugly. Might be
> nice to clean some of those up into a more readable form. But the
> patch looks correct so, and it looks like the rest of the IS_G33 checks
> already deal with PNV separately.

Agreed. But this is the required first step.

> I do wonder a bit about the IS_PINEVIEW_G and IS_PINEVIEW_M. I wonder if
> we should/could convert that to .is_mobile=true/false? Right now we seem
> to set .is_mobile=true for both.

Patches follow.

In the mean time, this one pushed, thanks for the review.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center


More information about the Intel-gfx mailing list