[Intel-gfx] [PATCH 09/11] drm/i915: Use primary plane->state for overlay ckey setup

Chris Wilson chris at chris-wilson.co.uk
Thu Dec 8 08:50:51 UTC 2016


On Wed, Dec 07, 2016 at 07:28:11PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> Extract the primary plane pixel format via plane state when setting up
> the overlay colorkey.
> 
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Minor stylistic differences aside (I would rearrange the code a bit more
to try and avoid having to initialise the locals, with the claim that it
keeps the code deciding upon the value together),
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list