[Intel-gfx] [PATCH 1/3] drm/i915: Introduct i915_platforms.h

[Tvrtko Ursulin]

On 08/12/2016 13:16, Joonas Lahtinen wrote:
> On to, 2016-12-08 at 12:41 +0200, Jani Nikula wrote:
>>> On Thu, 08 Dec 2016, Tvrtko Ursulin <tursulin at ursulin.net> wrote:
>>>
>>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>>
>>> Inspired by the same approach used by Chris Wilson in the self
>>> test patches.
>>>
>>> We add a separate header file containing the list of our
>>> platforms and then use the pre-processor to generate all
>>> other places which use that list. This avoids having to
>>> list them multiple times and avoids the maintenance
>>> burden.
>>>
>>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>>> Cc: Jani Nikula <jani.nikula at intel.com>
>>> Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
>
> <SNIP>
>
>> I was thinking we could improve the printed names here, for example:
>>
>> 	[INTEL_I965G] = "I965G/Broadwater"
>> 	[INTEL_VALLEYVIEW] = "Valleyview/Baytrail"
>>
>
> +1 on this idea!

Too much prettiness for the kernel I would have thought. Don't see the 
benefit personally.

Regards,

Tvrtko