[Intel-gfx] [PATCH 05/11] drm/i915: Use pipe_src_w in overlay code

Ville Syrjälä ville.syrjala at linux.intel.com
Thu Dec 8 16:11:09 UTC 2016


On Thu, Dec 08, 2016 at 08:35:48AM +0000, Chris Wilson wrote:
> On Wed, Dec 07, 2016 at 07:28:07PM +0200, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Replace the use of crtc->mode.h/vdisplay with the more appropriate
> > config->pipe_src_w/h.
> 
> I'll ask the dumb question: wouldn't pipe_src be the fb dimensions? It
> doesn't seem obvious to be they are the CRTC dimensions. Yes, they make
> sense from the pov this is the source rectangle that the CRTC is pulling
> pixels from. Hmm, hopefully I've answered my own question.

Indeed you have. The PIPESRC register name is a little confusing.
"Canvas size" or something along those lines might be less confusing.

> 
> Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list