[Intel-gfx] [PATCH v2] drm/i915: Respect num_pipes when install or reset dispaly IRQ

Wang, Elaine elaine.wang at intel.com
Mon Dec 12 06:39:35 UTC 2016


> On Fri, Dec 09, 2016 at 05:45:56PM +0200, Joonas Lahtinen wrote:
> > On pe, 2016-12-09 at 18:01 +0800, Wang Elaine wrote:
> > > From: Elaine Wang <elaine.wang at intel.com>
> > >
> > > Some platforms don't have display. To avoid accessing the
> > > non-existent registers, check whether num_pipes isn't zero before
> > > invoking dispaly IRQ install or reset function.
> > >
> > > Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
> > > Signed-off-by: Elaine Wang <elaine.wang at intel.com>
> >
> > Seems straightforward to me. A-b from Ville?
> 
> Once upon a time we used HAS_PCH_NOP(). How does that differ?
> -Chris
There is no difference. HAS_PCH_NOP() is equal to INTEL_INFO(dev_priv)->num_pipes == 0.
Let me modify the patch and use ! HAS_PCH_NOP() instead.
Thanks,
Elaine
> 
> --
> Chris Wilson, Intel Open Source Technology Centre
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx


More information about the Intel-gfx mailing list