[Intel-gfx] [PATCH 26/34] drm: Rename prev_node to hole in drm_mm_scan_add_block()

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Dec 13 15:23:54 UTC 2016


On ma, 2016-12-12 at 11:53 +0000, Chris Wilson wrote:
> Acknowledging that we were building up the hole was more useful to me
> when reading the code, than knowing the relationship between this node
> and the previous node.
> 

I don't really agree. I see that we have nodes and there are holes that
follow them, so prev_node makes more sense in that mindset.

node->scanned_preceeds_hole = hole->hole_follows; and
hole->hole_follows = 1; look especially quirky to me when read aloud.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list