[Intel-gfx] [PATCH 32/34] drm: Apply tight eviction scanning to color_adjust

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Dec 13 16:03:25 UTC 2016


On ma, 2016-12-12 at 11:53 +0000, Chris Wilson wrote:
> Using mm->color_adjust makes the eviction scanner much tricker since we
> don't know the actual neighbours of the target hole until after it is
> created (after scanning is complete). To work out whether we need to
> evict the neighbours because they impact upon the hole, we have to then
> check the hole afterwards - requiring an extra step in the user of the
> eviction scanner when they apply color_adjust.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

<SNIP>

> @@ -887,6 +872,33 @@ bool drm_mm_scan_remove_block(struct drm_mm_scan *scan,
>  }
>  EXPORT_SYMBOL(drm_mm_scan_remove_block);
>  
> +struct drm_mm_node *drm_mm_scan_color_evict(struct drm_mm_scan *scan)
> +

Kerneldoc so I can verify this function makes sense.

> diff --git a/drivers/gpu/drm/selftests/test-drm_mm.c b/drivers/gpu/drm/selftests/test-drm_mm.c
> index 09ead31a094d..73353f87f46a 100644
> --- a/drivers/gpu/drm/selftests/test-drm_mm.c
> +++ b/drivers/gpu/drm/selftests/test-drm_mm.c

Use helper func in this file?

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list