[Intel-gfx] [alsa-devel] [PATCH 5/7] ALSA: x86: hdmi: Improve position reporting

[Pierre-Louis Bossart]

On 12/14/16 8:36 AM, Takashi Iwai wrote:
> On Wed, 14 Dec 2016 15:09:20 +0100,
> Pierre-Louis Bossart wrote:
>>
>> On 12/14/16 6:57 AM, Takashi Iwai wrote:
>>> On Mon, 12 Dec 2016 19:10:41 +0100,
>>> Jerome Anand wrote:
>>>>
>>>> Use a hw register to calculate sub-period position reports.
>>>> This makes PulseAudio happier.
>>>>
>>>> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
>>>> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart at linux.intel.com>
>>>> Signed-off-by: Jerome Anand <jerome.anand at intel.com>
>>>
>>> There is no big merit to keep this a separate patch.
>>> Please fold into the main patch.
>>> You can put some comment in the code for explanation.
>>
>> The reason we kept this patch and the next separate is purely
>> procedural: they were contributed by Canonical in their Baytrail
>> Compute Stick kernel, and we didn't want to squash this blindly,
>> especially since David has gone silent.
>> I don't mind folding this code into the Intel patches but I wasn't
>> sure this was appropriate or even allowed.
>
> Merging the code must be OK, that's the point of the original patch
> having David's sign-off.  (If the code merge isn't allowed, how can we
> work on the kernel tree at all? ;)
> It'd be better, though, to mention about the merged code and his
> sign-off portion in the commit log.

ok, that's fine.