[Intel-gfx] [alsa-devel] [PATCH 1/7] drm/i915: setup bridge for HDMI LPE audio driver

[Pierre-Louis Bossart]

 >>> +static void lpe_audio_irq_unmask(struct irq_data *d) {
 >>> +	struct drm_i915_private *dev_priv = d->chip_data;
 >>> +	unsigned long irqflags;
 >>> +	u32 val = (I915_LPE_PIPE_A_INTERRUPT |
 >>> +		I915_LPE_PIPE_B_INTERRUPT);
 >>
 >> PIPE_C missing?
 >>
 >
 > No PIPE_C on vlv

Good catch Daniel.
We initially had PIPE_C everyhwere, thinking that it's harmless on 
Baytrail. Ville had a comment that there was no PIPE_C on BYT so we 
removed it for Baytrail-only code, here it makes no sense to me. we have 
the same problem in lpe_audio_irq_mask

 >> Besides the few bikesheds seems all reasonable, with those addressed
 >>
 >> Acked-by: Daniel Vetter <daniel.vetter at ffwll.ch>
 >>
 >
 > Thanks
 >
 >> ... for merging through sound tree. Since we're super early in 4.11 
a topic
 >> branch for me to pull in to avoid sync headaches would be good.

Thanks for the reviews and ack, we'll fix the comments shortly.