[Intel-gfx] [PATCH v2 36/40] drm: Wrap drm_mm_node.hole_follows

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Dec 16 13:41:50 UTC 2016


On pe, 2016-12-16 at 13:31 +0000, Chris Wilson wrote:
> On Fri, Dec 16, 2016 at 03:04:31PM +0200, Joonas Lahtinen wrote:
> > 
> > On pe, 2016-12-16 at 07:47 +0000, Chris Wilson wrote:
> > > 
> > > Insulate users from changed to the internal hole tracking within
> > 
> > changes ----------------^
> > 
> > > 
> > > struct drm_mm_node by using an accessor for hole_follows.
> > > 
> > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > 
> > The function name could be soemthing beginning with drm_mm_node...
> 
> Didn't like it as drm_mm_node_hole_follows(), and rationalised it away as
> saying this is really drm_mm state that happens to be hidden away insideĀ 
> the user's drm_mm_node. I guess we should look at some /* private */ markup.

That makes sense now that you mention it.

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list