[Intel-gfx] [PATCH v2 20/40] drm: kselftest for drm_mm and color eviction

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Fri Dec 16 14:38:12 UTC 2016


On pe, 2016-12-16 at 07:46 +0000, Chris Wilson wrote:
> Check that after applying the driver's color adjustment, eviction
> scanning find a suitable hole.
> 
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

<SNIP>

> +static int evict_color(struct drm_mm *mm,
> +		       struct evict_node *nodes,
> +		       unsigned int *order,
> +		       unsigned int count,
> +		       unsigned int size,
> +		       unsigned int alignment,
> +		       unsigned long color,
> +		       const struct insert_mode *mode)

expect_evict_color? evict_color gave me an impression of single-way
action (when reading the next patch).

Just a nitpick, so;

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Regards, Joonas
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list