[Intel-gfx] [PATCH 1/3] drm/i915: Expand is_lp backwards to gen8_lp and gen7_lp.

[Daniel Vetter]

On Sun, Dec 18, 2016 at 01:36:26PM -0800, Rodrigo Vivi wrote:
> Valleyview/Baytrail (gen7_lp) and Cherryview/Braswell (gen8_lp)
> are both Atom platforms like Broxton/Apollolake and Geminilake.
> 
> So let's expand this is_lp back to these platforms and
> create the IS_LP(dev_priv) so we can start simplifying a bit
> our if/else for platform lists.
> 
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.h | 1 +
>  drivers/gpu/drm/i915/i915_pci.c | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index 6217f01..e47273c 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -2829,6 +2829,7 @@ static inline struct scatterlist *__sg_next(struct scatterlist *sg)
>  #define IS_GEN9(dev_priv)	(!!((dev_priv)->info.gen_mask & BIT(8)))
>  
>  #define IS_GEN9_LP(dev_priv)	(IS_GEN9(dev_priv) && INTEL_INFO(dev_priv)->is_lp)
> +#define IS_LP(dev_priv)	(INTEL_INFO(dev_priv)->is_lp)
>  
>  #define ENGINE_MASK(id)	BIT(id)
>  #define RENDER_RING	ENGINE_MASK(RCS)
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 93f50ef..9885458 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -267,6 +267,7 @@
>  
>  #define VLV_FEATURES  \

Might want to inline this macro, it stopped being useful after
8d9c20e1d1e38. With or without that:

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>  	.gen = 7, .num_pipes = 2, \
> +	.is_lp = 1, \
>  	.has_psr = 1, \
>  	.has_runtime_pm = 1, \
>  	.has_rc6 = 1, \
> @@ -326,6 +327,7 @@
>  static const struct intel_device_info intel_cherryview_info = {
>  	.gen = 8, .num_pipes = 3,
>  	.has_hotplug = 1,
> +	.is_lp = 1,
>  	.ring_mask = RENDER_RING | BSD_RING | BLT_RING | VEBOX_RING,
>  	.platform = INTEL_CHERRYVIEW,
>  	.has_64bit_reloc = 1,
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch