[Intel-gfx] [PATCH v5 00/11] A collection of cleanups, revisited
david.s.gordon at intel.com
Fri Feb 5 18:33:37 UTC 2016
Various things can go wrong during initialisation and teardown, but they
usually don't, so the error-handling paths go largely untested. This
collection of patches fixes some things I recently noticed. Some might
lead to a kernel OOPS, but mostly they're leaks and other inconsistencies.
Includes Nick Hoath's patch to swap context/engine teardown, because that
helps make setup & teardown more consistent too; but more importantly, that
patch [10/11] is dependent on patch [9/11] of this set to work correctly.
Applying [10/11] without at least [9/11] as well may cause a fault on
Patches reordered and the previous [1/4] split into [4..6/6],
so that the bugs that it's fixing are more clearly visible
(Mika Kuoppala, although he said it wasn't actually *necessary*).
Patches reordered again; the bug fixes are now in patches 3 and 5.
The former could stand alone; the latter depends on patch 4 and is
a prerequisite for Nick's patch [6/6] to function.
Patches repartitioned, reordered, and rebased again.
The first two are now the ones that have already been reviewed
(R-b: Chris Wilson), the remaining ones have been broken up
into smaller more digestible chunks.
Dave Gordon (9):
drm/i915: unmap the correct page in intel_logical_ring_cleanup()
drm/i915: consolidate LRC mode HWSP setup & teardown
drm/i915: remove useless copypasted code
drm/i915: tidy up initialisation failure paths (GEM)
drm/i915: tidy initialisation failure paths (legacy, part 1)
drm/i915: tidy initialisation failure paths (legacy, part 2)
drm/i915: tidy initialisation failure paths (legacy, part 3)
drm/i915: tear down hardware status page mappings earlier
drm/i915: make LRC status page teardown code a bit more robust
Nick Hoath (2):
drm/i915: two small moves towards more consistency
drm/i915: interchange context/engine cleanup order
drivers/gpu/drm/i915/i915_dma.c | 4 +-
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 28 ++++++++------
drivers/gpu/drm/i915/intel_lrc.c | 65 ++++++++++++++++++++-------------
drivers/gpu/drm/i915/intel_ringbuffer.c | 40 ++++++++------------
5 files changed, 75 insertions(+), 64 deletions(-)
More information about the Intel-gfx