[Intel-gfx] [PATCH] drm/i915: Avoid vblank counter for gen9+

kbuild test robot lkp at intel.com
Fri Feb 12 01:32:29 UTC 2016


Hi Rodrigo,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.5-rc3 next-20160211]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Rodrigo-Vivi/drm-i915-Avoid-vblank-counter-for-gen9/20160212-090608
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x000-201606 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/linux/sysrq.h:18,
                    from drivers/gpu/drm/i915/i915_irq.c:31:
   drivers/gpu/drm/i915/i915_irq.c: In function 'intel_irq_init':
   drivers/gpu/drm/i915/i915_irq.c:4578:55: warning: comparison of constant '9' with boolean expression is always false [-Wbool-compare]
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
                                                          ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/gpu/drm/i915/i915_irq.c:4578:2: note: in expansion of macro 'if'
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
     ^
   drivers/gpu/drm/i915/i915_irq.c:4578:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
                                                          ^
   include/linux/compiler.h:147:28: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                               ^
>> drivers/gpu/drm/i915/i915_irq.c:4578:2: note: in expansion of macro 'if'
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
     ^
   drivers/gpu/drm/i915/i915_irq.c:4578:55: warning: comparison of constant '9' with boolean expression is always false [-Wbool-compare]
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
                                                          ^
   include/linux/compiler.h:147:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> drivers/gpu/drm/i915/i915_irq.c:4578:2: note: in expansion of macro 'if'
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
     ^
   drivers/gpu/drm/i915/i915_irq.c:4578:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
                                                          ^
   include/linux/compiler.h:147:40: note: in definition of macro '__trace_if'
     if (__builtin_constant_p((cond)) ? !!(cond) :   \
                                           ^
>> drivers/gpu/drm/i915/i915_irq.c:4578:2: note: in expansion of macro 'if'
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
     ^
   drivers/gpu/drm/i915/i915_irq.c:4578:55: warning: comparison of constant '9' with boolean expression is always false [-Wbool-compare]
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
                                                          ^
   include/linux/compiler.h:158:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> drivers/gpu/drm/i915/i915_irq.c:4578:2: note: in expansion of macro 'if'
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
     ^
   drivers/gpu/drm/i915/i915_irq.c:4578:55: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
                                                          ^
   include/linux/compiler.h:158:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^
>> drivers/gpu/drm/i915/i915_irq.c:4578:2: note: in expansion of macro 'if'
     if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
     ^

vim +/if +4578 drivers/gpu/drm/i915/i915_irq.c

  4562		} else if (IS_GEN2(dev_priv)) {
  4563			dev->max_vblank_count = 0;
  4564			dev->driver->get_vblank_counter = i8xx_get_vblank_counter;
  4565		} else if (IS_G4X(dev_priv) || INTEL_INFO(dev_priv)->gen >= 5) {
  4566			dev->max_vblank_count = 0xffffffff; /* full 32 bit counter */
  4567			dev->driver->get_vblank_counter = g4x_get_vblank_counter;
  4568		} else {
  4569			dev->driver->get_vblank_counter = i915_get_vblank_counter;
  4570			dev->max_vblank_count = 0xffffff; /* only 24 bits of frame count */
  4571		}
  4572	
  4573		/*
  4574		 * Opt out of the vblank disable timer on everything except gen2.
  4575		 * Gen2 doesn't have a hardware frame counter and so depends on
  4576		 * vblank interrupts to produce sane vblank seuquence numbers.
  4577		 */
> 4578		if (!IS_GEN2(dev_priv) && !INTEL_INFO(dev_priv)->gen >= 9)
  4579			dev->vblank_disable_immediate = true;
  4580	
  4581		dev->driver->get_vblank_timestamp = i915_get_vblank_timestamp;
  4582		dev->driver->get_scanout_position = i915_get_crtc_scanoutpos;
  4583	
  4584		if (IS_CHERRYVIEW(dev_priv)) {
  4585			dev->driver->irq_handler = cherryview_irq_handler;
  4586			dev->driver->irq_preinstall = cherryview_irq_preinstall;

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/octet-stream
Size: 24181 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20160212/56474b26/attachment-0001.obj>


More information about the Intel-gfx mailing list