[Intel-gfx] [PATCH 6/7] sna_video_sprite: add asserts to catch invalid pipe#
Martin Peres
martin.peres at linux.intel.com
Fri Feb 12 16:31:28 UTC 2016
Caught by Klockwork. This will be enough to catch those issues during
bringup.
Signed-off-by: Martin Peres <martin.peres at linux.intel.com>
---
src/sna/sna_video_sprite.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/sna/sna_video_sprite.c b/src/sna/sna_video_sprite.c
index 9e85049..ae08ef7 100644
--- a/src/sna/sna_video_sprite.c
+++ b/src/sna/sna_video_sprite.c
@@ -86,6 +86,7 @@ static int sna_video_sprite_stop(ddStopVideo_ARGS)
int pipe;
pipe = sna_crtc_pipe(crtc);
+ assert(pipe < ARRAY_SIZE(video->bo));
if (video->bo[pipe] == NULL)
continue;
@@ -260,6 +261,7 @@ sna_video_sprite_show(struct sna *sna,
video->color_key_changed &= ~(1 << pipe);
}
+ assert(pipe < ARRAY_SIZE(video->bo));
if (video->bo[pipe] == frame->bo)
return true;
@@ -415,6 +417,7 @@ static int sna_video_sprite_put_image(ddPutImage_ARGS)
RegionIntersect(®, ®, &clip);
if (RegionNil(®)) {
off:
+ assert(pipe < ARRAY_SIZE(video->bo));
if (video->bo[pipe]) {
struct local_mode_set_plane s;
memset(&s, 0, sizeof(s));
--
2.7.1
More information about the Intel-gfx
mailing list