[Intel-gfx] [PATCH i-g-t v3] lib/igt_core.c: Expand --run-subtest functionality.
Morton, Derek J
derek.j.morton at intel.com
Tue Feb 16 10:17:06 UTC 2016
>From: Gordon, David S
>Sent: Monday, February 15, 2016 7:29 PM
>To: Daniel Vetter <daniel at ffwll.ch>; Morton, Derek J <derek.j.morton at intel.com>
>Cc: intel-gfx at lists.freedesktop.org; Gore, Tim <tim.gore at intel.com>; david.weinehall at linux.intel.com; ville.syrjala at linux.intel.com; daniel.vetter at ffwll.ch
>Subject: Re: [PATCH i-g-t v3] lib/igt_core.c: Expand --run-subtest functionality.
>On 15/02/16 16:55, Daniel Vetter wrote:
>> On Thu, Feb 04, 2016 at 12:06:57PM +0000, Derek Morton wrote:
>>> Added extended wildcard support when specifying --run-subtest.
>>> Wildcard format is as specified in rfc3977 and the uwildmat()
>>> implementation is taken from libinn.
>>> See https://tools.ietf.org/html/rfc3977#section-4 for a description
>>> of allowed wildcard expressions.
>>> v2: Use comma as list separator (Ville Syrjala) support both ^ and !
>>> as not operators (Dave Gordon)
>>> v3: Updated to use uwildmat() (Dave Gordon)
>>> Signed-off-by: Derek Morton <derek.j.morton at intel.com>
>>> COPYING | 21 +++
>>> lib/Makefile.sources | 2 +
>>> lib/igt_core.c | 17 +-
>>> lib/uwildmat/uwildmat.c | 474 ++++++++++++++++++++++++++++++++++++++++++++++++
>>> lib/uwildmat/uwildmat.h | 24 +++
>> Not really a fan of copying other sources into ours. Don't we have
>> something ready-made that's generally available, or can we at least
>> pull it in as a build-dep?
>> Thanks, Daniel
>It's a standard, RFC3977. The source is readily available for download, for example from the INN master site
>It seems to be very stable (last change was 2014: "Change Russ' email address").
>It *is* already available (in Ubuntu at least), but it's in a fairly obscure package that not many people will have installed. On Ubuntu, /usr/lib/news/libinn.a is part of package 'inn2-dev'; I understand that on some other distros its in a different package (e.g. 'inn-devel' on CentOS).
>So this is probably why Derek chose to include the source from INN rather than working out how to make it a prerequisite for building i-g-t. And it almost certainly isn't otherwise available for Android!
It is not available in android by default and it seemed excessive to require anyone who wanted to use IGT to have to compile and install the internet news package just to pick up this file so I added the file in the patch.
The only 'simple' alternative I can see would be to introduce a new command line parameter 'run-subtest-regex' To allow regular expressions to be used, but using regular expressions to specify 'run all subtests except...' is not particularly pretty and the uwildmat solution is better in my opinion for expressing a subset of tests to run.
More information about the Intel-gfx