[Intel-gfx] [PATCH 0/3] Enable PSR by default in certain platforms

[Daniel Vetter]

On Fri, Feb 12, 2016 at 04:08:10AM -0800, Rodrigo Vivi wrote:
> For a long time we are trying to enable PSR by default everwhere
> but we always end up in soem specific corner case in one
> platform or another and end up not enabling in older stable platforms
> that could benefit from the power saving it provides.
> 
> So, let's change the approach here and try to enable it separated.
> 
> The new blocking issue is for Skylake and Kabylake due to a vblank
> wait situation with DMC firmware:
> https://bugs.freedesktop.org/show_bug.cgi?id=94126
> So that case will block PSR on SKL and KBL.
> 
> But  this doesn't affect at all other platforms that don't have DMC.
> 
> Also I decided to split the rest of platforms in two groups since
> Valleyview/Cherryview has a complete different Hardware PSR
> implementation than the rest of the platorms. Also it uses only
> link standby what should be safier.
> 
> So, 1 patch to add the possibility of enable per platform, 1 patch for
> VLV/CHV and 1 patch for HSW/BDW.
> 
> I hope to get SKL/KBL ready soon.
> 
> Thanks,
> Rodrigo.
> 
> Rodrigo Vivi (3):
>   drm/i915: Change i915.enable_psr parameter to use per platform
>     default.
>   drm/i915: Enable PSR by default on Valleyview and Cherryview.
>   drm/i915: Enable PSR by default on Haswell and Broadwell.

I don't really have a real opinion on the issue on patch 1 and don't mind
merging the patch as-is.

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch> on the entire series.

> 
>  drivers/gpu/drm/i915/i915_params.c | 5 +++--
>  drivers/gpu/drm/i915/intel_psr.c   | 9 +++++++++
>  2 files changed, 12 insertions(+), 2 deletions(-)
> 
> -- 
> 2.4.3
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch