[Intel-gfx] [PATCH 3/3] drm/i915: Derive GEM requests from dma-fence

[Chris Wilson]

On Mon, Jan 04, 2016 at 12:17:47PM +0000, Dave Gordon wrote:
> On 12/12/15 15:34, Chris Wilson wrote:
> >dma-buf provides a generic fence class for interoperation between
> >drivers. Internally we use the request structure as a fence, and so with
> >only a little bit of interfacing we can rebase those requests on top of
> >dma-buf fences. This will allow us, in the future, to pass those fences
> >back to userspace or between drivers.
> >
> >Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> >Cc: Jesse Barnes <jbarnes at virtuousgeek.org>
> >Cc: Daniel Vetter <daniel.vetter at ffwll.ch>
> >---
> >  drivers/gpu/drm/i915/i915_debugfs.c        |   2 +-
> >  drivers/gpu/drm/i915/i915_gem.c            |   2 +-
> >  drivers/gpu/drm/i915/i915_gem_request.c    | 128 ++++++++++++++++++++++++++---
> >  drivers/gpu/drm/i915/i915_gem_request.h    |  25 ++----
> >  drivers/gpu/drm/i915/i915_gpu_error.c      |   2 +-
> >  drivers/gpu/drm/i915/i915_guc_submission.c |   2 +-
> >  drivers/gpu/drm/i915/intel_breadcrumbs.c   |   3 +-
> >  drivers/gpu/drm/i915/intel_lrc.c           |   2 +-
> >  drivers/gpu/drm/i915/intel_ringbuffer.c    |  14 ++--
> >  9 files changed, 140 insertions(+), 40 deletions(-)
> 
> This seems to be doing the same thing as John Harrison's patch
> 
> [PATCH 05/13] drm/i915: Convert requests to use struct fence
> 
> Likewise you both have a patch to remove lazy coherency, and various
> other duplications:
> 
> [PATCH 06/13] drm/i915: Removed now redudant parameter to
> i915_gem_request_completed()
> [PATCH 08/13] drm/i915: Delay the freeing of requests until retire time
> 
> These will have to be unified; we just have to pick exactly how to
> make each of these improvements.

Indeed. This is my rebuttal of those patches since they did not
understand the issues involved.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre