[Intel-gfx] [RFC] drm/i915/bxt: Add pipe_src size property

Ville Syrjälä ville.syrjala at linux.intel.com
Mon Jan 4 09:06:15 PST 2016

On Mon, Jan 04, 2016 at 11:16:39AM +0100, Maarten Lankhorst wrote:
> Hey,
> Op 23-12-15 om 12:05 schreef Nabendu Maiti:
> > This patch is adding pipesource size as property as intel property.User
> > application is allowed to change the pipe source size in runtime on BXT/SKL.
> > Added the property as inteli crtc property.
> >
> > Comments and suggestions are requested for whether we can keep the
> > property as intel crtc property or move to drm level.
> >
> This property would get lost on a modeset. But why do you need a pipe_src property?

It's needed if we want to use the panel fitter with non-eDP/LVDS/DSI

Last time this came up I decided that we want to expose this via a new
"fixed_mode" property. Ie. userspace can choose the actual display
timings by setting the "fixed_mode" property with a specific mode, and
then the normal mode property will basically just control just the pipe
src size just like it already does for eDP/LVDS/DSI where we already have
the fixed_mode internally (just not exposed to usersapce). If the
fixed_mode is not specified, things will work just as they do right
now. Obviously for eDP/LVDS/DSI we will reject any request to
change/unset the fixed mode.

The benefit of that approach is that things will work exactly the same
way as before unless the user explicitly sets the fixed_mode, and once
it's set thigns will work exactly the same way as they have worked so
far for eDP/LVDS/DSI. Also it keeps the policy of choosing the fixed
mode strictly is userspace for external displays.

And as a bonus we will also expose the eDP/LVDS/DSI fixed_mode to
userspace giving userspace more information on what the actual panel
timings are. Currently userspace has to more or less guess that one
of the modes the connector claims to support has the actual panel

So far I've not heard any opposing opinions to this plan.

Ville Syrjälä
Intel OTC

More information about the Intel-gfx mailing list