[Intel-gfx] [PATCH] drm/i915/bxt: Don't save/restore eDP panel power during suspend

kbuild test robot lkp at intel.com
Tue Jan 5 18:06:38 PST 2016


Hi Matt,

[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on next-20160105]
[cannot apply to v4.4-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improving the system]

url:    https://github.com/0day-ci/linux/commits/Matt-Roper/drm-i915-bxt-Don-t-save-restore-eDP-panel-power-during-suspend/20160106-094646
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
config: x86_64-randconfig-x017-01041832 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/i915/i915_suspend.c: In function 'i915_save_display':
>> drivers/gpu/drm/i915/i915_suspend.c:52:33: warning: suggest parentheses around '&&' within '||' [-Wparentheses]
     } else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) {
                                    ^

vim +52 drivers/gpu/drm/i915/i915_suspend.c

    36		/* Display arbitration control */
    37		if (INTEL_INFO(dev)->gen <= 4)
    38			dev_priv->regfile.saveDSPARB = I915_READ(DSPARB);
    39	
    40		/* LVDS state */
    41		if (HAS_PCH_IBX(dev) || HAS_PCH_CPT(dev))
    42			dev_priv->regfile.saveLVDS = I915_READ(PCH_LVDS);
    43		else if (INTEL_INFO(dev)->gen <= 4 && IS_MOBILE(dev) && !IS_I830(dev))
    44			dev_priv->regfile.saveLVDS = I915_READ(LVDS);
    45	
    46		/* Panel power sequencer */
    47		if (HAS_PCH_SPLIT(dev)) {
    48			dev_priv->regfile.savePP_CONTROL = I915_READ(PCH_PP_CONTROL);
    49			dev_priv->regfile.savePP_ON_DELAYS = I915_READ(PCH_PP_ON_DELAYS);
    50			dev_priv->regfile.savePP_OFF_DELAYS = I915_READ(PCH_PP_OFF_DELAYS);
    51			dev_priv->regfile.savePP_DIVISOR = I915_READ(PCH_PP_DIVISOR);
  > 52		} else if (!IS_VALLEYVIEW(dev) && !IS_CHERRYVIEW(dev) || !IS_BROXTON(dev)) {
    53			dev_priv->regfile.savePP_CONTROL = I915_READ(PP_CONTROL);
    54			dev_priv->regfile.savePP_ON_DELAYS = I915_READ(PP_ON_DELAYS);
    55			dev_priv->regfile.savePP_OFF_DELAYS = I915_READ(PP_OFF_DELAYS);
    56			dev_priv->regfile.savePP_DIVISOR = I915_READ(PP_DIVISOR);
    57		}
    58	
    59		/* save FBC interval */
    60		if (HAS_FBC(dev) && INTEL_INFO(dev)->gen <= 4 && !IS_G4X(dev))

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/octet-stream
Size: 22771 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20160106/bc6a028d/attachment-0001.obj>


More information about the Intel-gfx mailing list