[Intel-gfx] [PATCH 1/4] drm: add support for generic zpos property

Daniel Vetter daniel at ffwll.ch
Thu Jan 7 06:44:46 PST 2016

On Thu, Jan 07, 2016 at 03:33:36PM +0100, Marek Szyprowski wrote:
> Hello,
> On 2016-01-07 14:59, Daniel Vetter wrote:
> >On Tue, Jan 05, 2016 at 01:52:50PM +0100, Marek Szyprowski wrote:
> >>This patch adds support for generic plane's zpos property property with
> >>well-defined semantics:
> >>- added zpos properties to drm core and plane state structures
> >>- added helpers for normalizing zpos properties of given set of planes
> >>- well defined semantics: planes are sorted by zpos values and then plane
> >>   id value if zpos equals
> >>
> >>Signed-off-by: Marek Szyprowski <m.szyprowski at samsung.com>
> >lgtm I think. Longer-term we want to think whether we don't want to
> >extract such extensions into separate files, and push the kerneldoc into
> >an overview DOC: section in there. Just to keep things more closely
> >together. Benjamin with drm/sti also needs this, so cc'ing him.
> Besides sti and exynos, zpos is also already implemented in rcar, mdp5 and
> omap
> drivers. I'm not sure what should be done in case of omap, which uses this
> property
> with different name ("zorder" instead of "zpos").

Argh, it escaped badly already :( Wrt omap I'd just leave it be (atomic
conversion should maybe try to get rid of it though), but for everyone
else it would indeed be nice if the could convert over ... Mostly it
should boil down to removing/replacing code to register the prop, and
looking at the new core one to figure out what to do.
Daniel Vetter
Software Engineer, Intel Corporation

More information about the Intel-gfx mailing list