[Intel-gfx] [PATCH 10/15] drm/i915/bios: add sequences for MIPI sequence block v2

[Ville Syrjälä]

On Thu, Jan 07, 2016 at 04:54:00PM +0200, Jani Nikula wrote:
> On Thu, 07 Jan 2016, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> > On Mon, Dec 21, 2015 at 03:11:01PM +0200, Jani Nikula wrote:
> >> Properly parse the new sequences added in MIPI sequence block v2.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> >> ---
> >>  drivers/gpu/drm/i915/intel_bios.h | 3 +++
> >>  1 file changed, 3 insertions(+)
> >> 
> >> diff --git a/drivers/gpu/drm/i915/intel_bios.h b/drivers/gpu/drm/i915/intel_bios.h
> >> index 411b33794536..6146f1b0cf48 100644
> >> --- a/drivers/gpu/drm/i915/intel_bios.h
> >> +++ b/drivers/gpu/drm/i915/intel_bios.h
> >> @@ -960,6 +960,9 @@ enum mipi_seq {
> >>  	MIPI_SEQ_DISPLAY_ON,
> >>  	MIPI_SEQ_DISPLAY_OFF,
> >>  	MIPI_SEQ_DEASSERT_RESET,
> >> +	MIPI_SEQ_BACKLIGHT_ON,		/* sequence block v2+ */
> >> +	MIPI_SEQ_BACKLIGHT_OFF,		/* sequence block v2+ */
> >> +	MIPI_SEQ_TEAR_ON,		/* sequence block v2+ */
> >
> > Can't comment on the v2+ part since the spec fails to mention it, but
> > otherwise looks sane.
> >
> > It's a bit hard to review w/o an explicit assignments for each, but
> > assuming the MIPI_SEQ_DEASSERT_RESET value is correct these should be
> > correct too.
> >
> > Not sure why we stopped at "tear on" though? The spec has "tear off",
> > "panel on" and "panel off" listed as well.
> 
> Just for lols. The sequence block v2 stops there. The rest are added at
> v3. Words fail me.

Okay, that's a good enough excuse in my book:

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> 
> BR,
> Jani.
> 
> >
> >>  	MIPI_SEQ_MAX
> >>  };
> >>  
> >> -- 
> >> 2.1.4
> >> 
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx at lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Jani Nikula, Intel Open Source Technology Center

-- 
Ville Syrjälä
Intel OTC