[Intel-gfx] [PATCH] drm/i915: Cleaning up DDI translation tables

[Ville Syrjälä]

On Tue, Jan 05, 2016 at 11:18:55AM -0800, Rodrigo Vivi wrote:
> No functional changes.
> 
> That state the obvious and just duplicate the place we
> need to change whenever the table is updated. So let's clean it.
> 
> Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index bc8a497..d3611f5 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -133,12 +133,12 @@ static const struct ddi_buf_trans skl_ddi_translations_dp[] = {
>  	{ 0x00002016, 0x000000A0, 0x0 },
>  	{ 0x00005012, 0x0000009B, 0x0 },
>  	{ 0x00007011, 0x00000088, 0x0 },
> -	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80009010, 0x000000C0, 0x1 },
>  	{ 0x00002016, 0x0000009B, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
> -	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80007011, 0x000000C0, 0x1 },
>  	{ 0x00002016, 0x000000DF, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80005012, 0x000000C0, 0x1 },
>  };
>  
>  /* Skylake U */
> @@ -146,12 +146,12 @@ static const struct ddi_buf_trans skl_u_ddi_translations_dp[] = {
>  	{ 0x0000201B, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
>  	{ 0x80007011, 0x000000CD, 0x0 },
> -	{ 0x80009010, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80009010, 0x000000C0, 0x1 },
>  	{ 0x0000201B, 0x0000009D, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> -	{ 0x80007011, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80005012, 0x000000C0, 0x1 },
> +	{ 0x80007011, 0x000000C0, 0x1 },
>  	{ 0x00002016, 0x00000088, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x1 },	/* Uses I_boost level 0x1 */
> +	{ 0x80005012, 0x000000C0, 0x1 },
>  };
>  
>  /* Skylake Y */
> @@ -159,12 +159,12 @@ static const struct ddi_buf_trans skl_y_ddi_translations_dp[] = {
>  	{ 0x00000018, 0x000000A2, 0x0 },
>  	{ 0x00005012, 0x00000088, 0x0 },
>  	{ 0x80007011, 0x000000CD, 0x0 },
> -	{ 0x80009010, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80009010, 0x000000C0, 0x3 },
>  	{ 0x00000018, 0x0000009D, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> -	{ 0x80007011, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80005012, 0x000000C0, 0x3 },
> +	{ 0x80007011, 0x000000C0, 0x3 },
>  	{ 0x00000018, 0x00000088, 0x0 },
> -	{ 0x80005012, 0x000000C0, 0x3 },	/* Uses I_boost level 0x3 */
> +	{ 0x80005012, 0x000000C0, 0x3 },
>  };
>  
>  /*
> -- 
> 2.4.3

-- 
Ville Syrjälä
Intel OTC