[Intel-gfx] [PATCH 2/3] drm/i915: Don't warn if the workaround list is empty part 2.

Rodrigo Vivi rodrigo.vivi at gmail.com
Thu Jan 7 16:49:45 PST 2016


Daniel, Ack?

So I can merge this and the missing IS_KABYLAKE ones...

The preliminary one I agree with you and will put a request for KBL on CI.

Thanks in advance,
Rodrigo.

On Wed, Jan 6, 2016 at 5:15 PM Rodrigo Vivi <rodrigo.vivi at intel.com> wrote:

> From: "Boyer, Wayne" <wayne.boyer at intel.com>
>
> Extend the same reasoning as in the patch listed below.  It's not an
> error for the workaround list to be empty if no workarounds are needed.
>
>     commit 02235808b61cd9382d224b0df263193006dd9913
>     Author: Francisco Jerez <currojerez at riseup.net>
>     Date:   Wed Oct 7 14:44:01 2015 +0300
>         drm/i915: Don't warn if the workaround list is empty.
>
> Signed-off-by: Wayne Boyer <wayne.boyer at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
>  drivers/gpu/drm/i915/intel_lrc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c
> b/drivers/gpu/drm/i915/intel_lrc.c
> index 8096c6a..641d21c 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -1100,7 +1100,7 @@ static int
> intel_logical_ring_workarounds_emit(struct drm_i915_gem_request *req)
>         struct drm_i915_private *dev_priv = dev->dev_private;
>         struct i915_workarounds *w = &dev_priv->workarounds;
>
> -       if (WARN_ON_ONCE(w->count == 0))
> +       if (w->count == 0)
>                 return 0;
>
>         ring->gpu_caches_dirty = true;
> --
> 2.4.3
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20160108/07e155aa/attachment.html>


More information about the Intel-gfx mailing list