[Intel-gfx] [PATCH 2/2] drm/i915: Arm the unclaimed mmio debugs on suspend path

[Chris Wilson]

On Fri, Jan 08, 2016 at 03:51:20PM +0200, Mika Kuoppala wrote:
> If we go into suspend with unclaimed access detected,
> it would be nice to catch that access on a next suspend path.
> So instead of just notifying about it, arm the unclaimed
> mmio checks on suspend side.
> 
> We want to keep the asymmetry on resume, as if it was
> on resume path, it was not driver that is responsible so
> no point in arming mmio debugs.
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

I actually even like the extra DRM_ERROR here. Driver unload is another
candidate for

  if (intel_uncore_unclaimed_mmio(dev_priv))
	DRM_ERROR("Unclaimed access detected prior to unload\n");

Might as well tickle the CI if nothing else.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre