[Intel-gfx] [PATCH 7/7] drm/i915: GEM operations need to be done under the big lock

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Jan 11 06:47:17 PST 2016


On 11/01/16 14:38, Chris Wilson wrote:
> On Mon, Jan 11, 2016 at 02:08:41PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> VMA creation and GEM list management need the big lock.
>>
>> v2:
>>
>> Mutex unlock ended on the wrong path somehow. (0-day, Julia Lawall)
>>
>> Not to mention drm_gem_object_unreference was there in existing
>> code with no mutex held.
>>
>> v3:
>>
>> Some callers of i915_gem_object_create_stolen_for_preallocated
>> already hold the lock so move the mutex into the other caller
>> as well.
>
> intel_pm.c valleyview_setup_pctx?

Already holds it traced by the WARN_ON at its top.

Regards,

Tvrtko


More information about the Intel-gfx mailing list