[Intel-gfx] [PATCH 5/7] drm/i915: Don't need a timer to wake us up

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Tue Jan 12 02:20:01 PST 2016


On 11/01/16 14:33, Chris Wilson wrote:
> On Mon, Jan 11, 2016 at 02:08:39PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> We can avoid open-coding the schedule wake-up since
>>
>>     commit 9cff8adeaa34b5d2802f03f89803da57856b3b72
>>     Author: NeilBrown <neilb at suse.de>
>>     Date:   Fri Feb 13 15:49:17 2015 +1100
>>
>>         sched: Prevent recursion in io_schedule()
>>
>> exported the io_schedule_timeout function which we can now use
>> to simplify the code in __i915_wait_request.
>>
>> v2: New commit message. (Daniel Vetter)
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Chris Wilson <chris at chris-wilson.co.uk>
>> Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
>
> I don't like this because the timer concept still turns out to be useful
> when we separate the timer from the bottom-half. And so we have a patch
> to remove it and then we add it back again because it serves a purpose.

-EWHATEVER

Regards,

Tvrtko


More information about the Intel-gfx mailing list