[Intel-gfx] [PATCH 1/2] drm/i915/gen8: Tidy display interrupt processing

[Tvrtko Ursulin]

On 12/01/16 17:12, Chris Wilson wrote:
> On Tue, Jan 12, 2016 at 04:04:06PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> One bugfix and a few tidy-ups:
>>
>>   * Pipe fault logging was broken on Gen9+.
>>   * Removed some unnecessary local variables.
>>   * Removed unnecessary initializers.
>>   * Decreased pipe iir block indentation level.
>>   * Grouped variable initialization close to use sites.
>
> Out of curiosity did the compiled output change from the changes in
> local variables? I'd slap a much-appreciated-by on anything that could
> reduce the instruction count in our interrupt handlers!
>
> Didn't spot any mistakes, so
>
> Reviewed-by: Chris Wilson <chris at cris-wilson.co.uk>
>
> but I'd like to give some extra credit if you have shrunk this beast.

Two steps forward, one step back. :)

vanilla:
0000000000005630 0000000000000668 t gen8_irq_handler

+drm/i915/gen8: Tidy display interrupt processing
0000000000005630 0000000000000633 t gen8_irq_handler

++drm/i915/gen8: Factor out display interrupt handling
0000000000005630 000000000000065c t gen8_irq_handler

Thanks for the review!

Regards,

Tvrtko