[Intel-gfx] [PATCH 1/3] drm/i915: Extract vfunc setup from logical ring initializers

Chris Wilson chris at chris-wilson.co.uk
Tue Jan 12 13:43:05 PST 2016

On Tue, Jan 12, 2016 at 05:32:34PM +0000, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Majority of them was duplicated code and only render ring
> currently overrides some of them. We can save some lines of
> code and also take away the confusion on why bsd2 did not
> do the seqno coherency workaround. (VCS2 ring does not exist
> on platforms where workaround is needed but that was not
> documented in the code.)
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

All 3,
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>

We can even combine several functions by inheriting the vfuncs from
intel_ringbuffer.c, and ~only overloading the init/add_request vfuncs.
i.e. call intel_blah_engine_init_execlists after setuping the legacy vfuncs
and common init from intel_blah_engine_init. At the same time, we can
apply some of the same improvements (such as irq_enable_mask) back to the
older gen.

Chris Wilson, Intel Open Source Technology Centre

More information about the Intel-gfx mailing list