[Intel-gfx] [PATCH 14/22] drm/imx: Unconfuse preclose logic
p.zabel at pengutronix.de
Tue Jan 12 00:57:28 PST 2016
Am Montag, den 11.01.2016, 22:41 +0100 schrieb Daniel Vetter:
> So this one is special, since it tries to prevent races when userspace
> crashes simply by disabling the vblank machinery. Well except that imx
> always has vblanks enabled, and the disable_vblank hook actually just
> tries to cancel a pending pageflip. Without any locking whatsoever. Of
> course this is wrong, since it'll result in the hw not actually
> displaying what drm thinks is the current frontbuffer.
> Well since the core takes care of the disappearing DRM fd now. So we
> can nuke all this confused code without ill side-effects.
> Someone else needs to audit the locking for ->newfb and
> ->page_flip_event and fix it up. Common approach is to reuse
> dev->event_lock for this.
> Cc: Sascha Hauer <s.hauer at pengutronix.de>
> Cc: Philipp Zabel <p.zabel at pengutronix.de>
> Acked-by: Daniel Stone <daniels at collabora.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
Acked-by: Philipp Zabel <p.zabel at pengutronix.de>
More information about the Intel-gfx