[Intel-gfx] [PATCH] drm/i915: Codify our assumption that the Global GTT is <= 4GiB

Ville Syrjälä ville.syrjala at linux.intel.com
Fri Jan 15 04:49:23 PST 2016


On Fri, Jan 15, 2016 at 11:28:16AM +0000, Chris Wilson wrote:
> On Fri, Jan 15, 2016 at 10:20:11AM +0000, Chris Wilson wrote:
> > Throughout the code base, we use u32 for offsets into the global GTT. If
> > we ever see any hardware with a larger GGTT, then we run the real risk
> > of silent corruption. So test for our assumption up front so that we
> > have a nice reminder should the time come when it fails.
> > 
> > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
> > Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > Cc: Daniel Vetter <daniel at ffwll.ch>
> 
> >From the earlier cut-n-paste,
> 
> Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> (so I hope it still holds with the minor correction applied :)

Yes. Please excuse the sucky review I gave to the original.

-- 
Ville Syrjälä
Intel OTC


More information about the Intel-gfx mailing list