[Intel-gfx] [PATCH v2] drm/i915/guc: Fix a memory leak where guc->execbuf_client is not freed

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Mon Jan 18 02:01:24 PST 2016


On 13/01/16 19:11, Dave Gordon wrote:
> On 13/01/16 19:01, yu.dai at intel.com wrote:
>> From: Alex Dai <yu.dai at intel.com>
>>
>> During driver unloading, the guc_client created for command submission
>> needs to be released to avoid memory leak.
>>
>> The struct_mutex needs to be held before tearing down GuC.
>>
>> v1: Move i915_guc_submission_disable out of i915_guc_submission_fini and
>>      take struct_mutex lock before release GuC client. (Dave Gordon)
>> v2: Add the locking for failure case in guc_fw_fetch. (Dave Gordon)
>>      Add i915_guc_submission_fini for failure case in
>> intel_guc_ucode_load.
>>
>> Signed-off-by: Alex Dai <yu.dai at intel.com>
>
> LGTM.
>
> Reviewed-by: Dave Gordon <david.s.gordon at intel.com>

Patch merged, thanks!

Regards,

Tvrtko


More information about the Intel-gfx mailing list