[Intel-gfx] [PATCH] drm/i915: Allow i915_gem_object_get_page() on userptr as well

Kristian Høgsberg krh at bitplanet.net
Thu Jan 21 15:28:45 PST 2016


On Wed, Jan 13, 2016 at 11:08 AM, Dave Gordon <david.s.gordon at intel.com> wrote:
> On 12/01/16 23:49, Chris Wilson wrote:
>>
>> On Tue, Jan 12, 2016 at 11:40:06PM +0000, Chris Wilson wrote:
>>>
>>>   struct drm_i915_gem_object_ops {
>>> +       const unsigned int flags;
>>
>>
>> Bleh, const is redundant as the definitions should be const themselves.
>> -Chris
>
>
> Yeah, the const-ness attaches to the instances of and references to the
> structure rather than the abstract type. But it doesn't actually do any
> harm, so with or without the redundant 'const' it gets:
>
> Reviewed-by: Dave Gordon <david.s.gordon at intel.com>
>

Fixes the crash I was seeing with relocs in a userptr bo.

Reviewed-by: Kristian Høgsberg <krh at bitplanet.net>


More information about the Intel-gfx mailing list