[Intel-gfx] [PATCH 1/4] drm/i915: handle teardown of HWSP when context is freed

Chris Wilson chris at chris-wilson.co.uk
Fri Jan 22 02:35:52 PST 2016


On Fri, Jan 22, 2016 at 12:28:22PM +0200, Mika Kuoppala wrote:
> As the page is always kmapped along with setting of status_page.obj,
> I fail to see why we need the check here for the page_addr.
> 
> How about just:
> 
> if (WARN_ON(!dctx_obj))
>    return;

Just let it die in a GPF. We already have code to detect impossible
situations.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre


More information about the Intel-gfx mailing list