[Intel-gfx] [PATCH] Fix pointer tests in error-handling paths

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Jan 22 05:17:44 PST 2016

On 22/01/16 13:01, Chris Wilson wrote:
> On Fri, Jan 22, 2016 at 12:19:32PM +0000, Dave Gordon wrote:
>> In the error-handling paths of i915_gem_do_execbuffer() and
>> intel_crtc_page_flip(), the local pointer-to-request variables
>> were expected to be either valid pointers or NULL. Since
>>    2682708 drm/i915: simplify allocation of driver-internal requests
>> they could also be ERR_PTR() values, so the tests need to be
>> updated to accommodate this case.
>> Signed-off-by: Dave Gordon <david.s.gordon at intel.com>
>> Cc: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
> Quick quiz, name at least testcase that exercised this code?

gem_close_race did it for me, but can you explain the weird ERR_PTR of 
*ffca ? :)



More information about the Intel-gfx mailing list