[Intel-gfx] [PATCH v2] Fix pointer tests in error-handling paths

Maarten Lankhorst maarten.lankhorst at linux.intel.com
Wed Jan 27 04:33:36 PST 2016


Op 25-01-16 om 18:57 schreef Dave Gordon:
> In the error-handling paths of i915_gem_do_execbuffer() and
> intel_crtc_page_flip(), the local pointer-to-request variables
> were expected to be either valid pointers or NULL. Since
>   2682708 drm/i915: simplify allocation of driver-internal requests
> they could also be ERR_PTR() values, so the tests need to be
> updated to accommodate this case.
> v2:    Added testcase (Chris Wilson)
> Testcase: igt/gem_close_race
> Signed-off-by: Dave Gordon <david.s.gordon at intel.com>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
The testcase you mentioned doesn't work, it crashes on my machine instead of running to completion or triggering the bug.

gem_ringfill.default-interruptible seems to trigger it.


More information about the Intel-gfx mailing list