[Intel-gfx] [PATCH] drm/i915: Capture revision id in error state

[Chris Wilson]

On Wed, Jan 27, 2016 at 11:44:07AM +0000, Arun Siluvery wrote:
> On 27/01/2016 11:33, Ville Syrjälä wrote:
> >On Tue, Jan 26, 2016 at 05:52:51PM +0000, Arun Siluvery wrote:
> >>Revision id along with device id is useful in better identification of the HW
> >>and its limitations so include this detail in error state.
> >>
> >>Signed-off-by: Arun Siluvery <arun.siluvery at linux.intel.com>
> >>---
> >>  drivers/gpu/drm/i915/i915_gpu_error.c | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >>diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>index 7eeb244..f3ddc3b 100644
> >>--- a/drivers/gpu/drm/i915/i915_gpu_error.c
> >>+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> >>@@ -365,6 +365,7 @@ int i915_error_state_to_str(struct drm_i915_error_state_buf *m,
> >>  	err_printf(m, "Reset count: %u\n", error->reset_count);
> >>  	err_printf(m, "Suspend count: %u\n", error->suspend_count);
> >>  	err_printf(m, "PCI ID: 0x%04x\n", dev->pdev->device);
> >>+	err_printf(m, "Revision: 0x%02x\n", dev->pdev->revision);
> >
> >"PCI revision" maybe?
> sure, makes it more clear.

We also use the subvendor ids, so if we might as well dump the full PCI
ID whilst we are making an adjustment here.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre