[Intel-gfx] [PATCH] drm/i915: Set the access right of kernel param "i915.enable_gvt" to read-only.

Joonas Lahtinen joonas.lahtinen at linux.intel.com
Tue Jul 12 10:50:09 UTC 2016


On ma, 2016-06-20 at 08:17 -0400, Zhi Wang wrote:
> The access right of kernel param "i915.enable_gvt" should be read-only as
> it only applies during module load (and is not *runtime* writable).
> 
> Cc: Chris Wilson <chris at chris-wilson.co.uk>

Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>

Maybe also add,

Suggested-by: Chris Wilson <chris at chris-wilson.co.uk>

> Signed-off-by: Zhi Wang <zhi.a.wang at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_params.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 7effe68..8b13bfa 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -224,6 +224,6 @@ module_param_named(enable_dpcd_backlight, i915.enable_dpcd_backlight, bool, 0600
>  MODULE_PARM_DESC(enable_dpcd_backlight,
>  	"Enable support for DPCD backlight control (default:false)");
>  
> -module_param_named(enable_gvt, i915.enable_gvt, bool, 0600);
> +module_param_named(enable_gvt, i915.enable_gvt, bool, 0400);
>  MODULE_PARM_DESC(enable_gvt,
>  	"Enable support for Intel GVT-g graphics virtualization host support(default:false)");
-- 
Joonas Lahtinen
Open Source Technology Center
Intel Corporation


More information about the Intel-gfx mailing list